Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filename in configure_openssl_crypto_policy #5885

Merged

Conversation

vojtapolasek
Copy link
Collaborator

@vojtapolasek vojtapolasek commented Jun 25, 2020

Description:

Rewrite openssl.config to opensslcnf.config in description, ocil, oval, bash, ansible, tests.

Rationale:

The file openssl.config is not expected to be included into openssl.cnf config file. The correct file is opensslcnf.config. Remediation of this rule was causing problems with openssl.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1850543

@vojtapolasek vojtapolasek added this to the 0.1.51 milestone Jun 25, 2020
@ggbecker
Copy link
Member

@openscap-ci retest this please

@ggbecker
Copy link
Member

/test e2e-aws-rhcos4-e8

@ggbecker ggbecker self-assigned this Jun 25, 2020
Copy link
Member

@ggbecker ggbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small nitpicks in ansible task name, changes approved.

@ggbecker ggbecker merged commit abde156 into ComplianceAsCode:master Jun 26, 2020
@mildas
Copy link
Contributor

mildas commented Jun 26, 2020

Changes identified:
Rule configure_openssl_crypto_policy:
 Found change in bash remediation.
 Ansible remediation changed.
 Text changed in OVAL check.

Recommended tests to execute:
 build_product ol8
 tests/test_suite.py rule --libvirt qemu:///system test-suite-vm --remediate-using ansible --datastream build/ssg-ol8-ds.xml configure_openssl_crypto_policy
 tests/test_suite.py rule --libvirt qemu:///system test-suite-vm --remediate-using bash --datastream build/ssg-ol8-ds.xml configure_openssl_crypto_policy

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants