Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zIPL rule for PTI bootloader option #6065

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

yuumasato
Copy link
Member

Description:

  • Remove zIPL rule for PTI bootloader option

Rationale:

  • This setting is to mitigate a problem specific for Intel archs

@redhatrises
Copy link
Contributor

Are you going to add the CCE back to the pool since this rule was never really used?

@yuumasato
Copy link
Member Author

Are you going to add the CCE back to the pool since this rule was never really used?

I can, why not.

@matejak
Copy link
Member

matejak commented Sep 18, 2020

Are you going to add the CCE back to the pool since this rule was never really used?

I can, why not.

Better pick a random place in the file next time :-)

@matejak matejak added this to the 0.1.53 milestone Sep 18, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Used by openshift-ci bot. label Sep 19, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Used by openshift-ci bot. label Sep 21, 2020
@yuumasato
Copy link
Member Author

Rebased

This setting is to mitigate a problem specific for intel archs.
Also returns the CCE to the pool.
@mildas
Copy link
Contributor

mildas commented Sep 21, 2020

Changes identified:
Profile ospp on rhel8:
 Rule zipl_pti_argument removed from ospp profile.
Profile ospp-mls on rhel8:
 OSPP-MLS profile extends changed OSPP profile.
Profile rhelh-vpp on rhel8:
 RHELH-VPP profile extends changed OSPP profile.
Profile cui on rhel8:
 CUI profile extends changed OSPP profile.
Profile stig on rhel8:
 Rule !zipl_pti_argument removed from stig profile.
 STIG profile extends changed OSPP profile.
Profile rhelh-stig on rhel8:
 RHELH-STIG profile extends changed STIG profile.
Profile ospp on tests:
 Rule zipl_pti_argument removed from ospp profile.

Recommended tests to execute:
 build_product tests
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-tests-ds.xml ospp
 build_product rhel8
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhel8-ds.xml ospp
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhel8-ds.xml ospp-mls
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhel8-ds.xml rhelh-vpp
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhel8-ds.xml cui
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhel8-ds.xml stig
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhel8-ds.xml rhelh-stig

@yuumasato
Copy link
Member Author

Are you going to add the CCE back to the pool since this rule was never really used?

The rule is now part of 0.1.52 release, so I'll won't drop the CCE anymore.

@matejak
Copy link
Member

matejak commented Sep 22, 2020

Merging, thanks!

@matejak matejak merged commit 3b89d40 into ComplianceAsCode:master Sep 22, 2020
@yuumasato yuumasato deleted the drop-pti-for-zipl branch September 22, 2020 12:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants