Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw warning when ocp4 and rhcos4 content fail on scapval #6107

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

ggbecker
Copy link
Member

@ggbecker ggbecker commented Sep 21, 2020

Description:

  • Throw warning when ocp4 content fail on scapval.

Rationale:

  • At this moment, the content validation always fail because it contains the non-standardized content (yamlfilecontent_test). With a warning instead, we can keep the job always green and whenever a fail occurs, we can assume it's a legit one.

@ggbecker ggbecker added the standards Benchmarks related. label Sep 21, 2020
@ggbecker ggbecker added this to the 0.1.53 milestone Sep 21, 2020
@pep8speaks
Copy link

pep8speaks commented Sep 21, 2020

Hello @ggbecker! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 45:100: E501 line too long (103 > 99 characters)

Comment last updated at 2020-09-21 10:11:01 UTC

@jan-cerny jan-cerny self-assigned this Sep 21, 2020
@jan-cerny jan-cerny changed the title Throw warning when ocp4 and rhcos4 content fail on scapval. Throw warning when ocp4 and rhcos4 content fail on scapval Sep 21, 2020
@mildas
Copy link
Contributor

mildas commented Sep 21, 2020

Changes identified:
Others:
 Python abstract syntax tree change found in tests/run_scapval.py.

Recommended tests to execute:
 (cd build && cmake ../ && ctest -j4)

@jan-cerny jan-cerny merged commit be459e8 into ComplianceAsCode:master Sep 21, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
standards Benchmarks related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants