Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated sshd config from e8 profile #6120

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

shaneboulden
Copy link
Contributor

Description:

@openshift-ci-robot
Copy link
Collaborator

Hi @shaneboulden. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Used by openshift-ci bot. label Sep 24, 2020
@redhatrises
Copy link
Contributor

Ack

Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind removing it from the rhcos4 profiles as well?

@jan-cerny
Copy link
Collaborator

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Sep 25, 2020
The sshd_config UsePrivilegeSeparation option is deprecated
The sshd_config UsePrivilegeSeparation option is deprecated
@mildas
Copy link
Contributor

mildas commented Sep 27, 2020

Changes identified:
Profile e8 on rhcos4:
 Rule sshd_use_priv_separation removed from e8 profile.
Profile e8 on rhel7:
 Rule sshd_use_priv_separation removed from e8 profile.
Profile hipaa on rhel7:
 Rule sshd_use_priv_separation removed from hipaa profile.
Profile e8 on rhel8:
 Rule sshd_use_priv_separation removed from e8 profile.
Profile ism_o on rhel8:
 ISM_O profile extends changed E8 profile.
Profile hipaa on rhel8:
 Rule sshd_use_priv_separation removed from hipaa profile.
Profile e8 on tests:
 Rule sshd_use_priv_separation removed from e8 profile.

Recommended tests to execute:
 build_product rhel7
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhel7-ds.xml e8
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhel7-ds.xml hipaa
 build_product rhel8
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhel8-ds.xml ism_o
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhel8-ds.xml e8
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhel8-ds.xml hipaa
 build_product tests
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-tests-ds.xml e8
 build_product rhcos4
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhcos4-ds.xml e8

@shaneboulden
Copy link
Contributor Author

@JAORMX I've removed this from the E8 RHCOS profile.

@redhatrises I also noticed this check in the HIPAA profiles for RHEL7/RHEL8 - I've added a separate commit here, I can drop it out if you want to retain the config option.

@shaneboulden
Copy link
Contributor Author

/retest

1 similar comment
@JAORMX
Copy link
Contributor

JAORMX commented Sep 28, 2020

/retest

@redhatrises
Copy link
Contributor

/lgtm

@redhatrises redhatrises merged commit cc585f3 into ComplianceAsCode:master Sep 28, 2020
@yuumasato yuumasato added this to the 0.1.53 milestone Oct 27, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants