ocp4: fix basic-auth check

[JAORMX]

The check is now done through an API check.

[JAORMX]

Pull-request updated, HEAD is now 8e0c9d0

[JAORMX]

Pull-request updated, HEAD is now 1f7c5b0

[jhrozek]

/lgtm

[jhrozek]

Oops, sorry, I might have acked too soon, RHEL-6 and 7 are complaining:

Exception while handling file: /home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/build/ocp4/rules/api_server_basic_auth.yml
Traceback (most recent call last):
  File "/home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/build-scripts/build_templated_content.py", line 56, in <module>
    builder.build()
  File "/home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/ssg/templates.py", line 550, in build
    self.build_all_rules()
  File "/home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/ssg/templates.py", line 528, in build_all_rules
    rule = ssg.build_yaml.Rule.from_yaml(rule_path, self.env_yaml)
  File "/home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/ssg/build_yaml.py", line 878, in from_yaml
    yaml_contents = open_and_macro_expand(yaml_file, env_yaml)
  File "/home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/ssg/yaml.py", line 126, in open_and_macro_expand
    return open_and_expand(yaml_file, substitutions_dict)
  File "/home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/ssg/yaml.py", line 109, in open_and_expand
    yaml_contents = _open_yaml(expanded_template, yaml_file, substitutions_dict)
  File "/home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/ssg/yaml.py", line 75, in _open_yaml
    raise e
yaml.constructor.ConstructorError: could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
  in "<unicode string>", line 40, column 15
gmake[2]: *** [ocp4/templated-content-ocp4] Error 1
gmake[1]: *** [ocp4/CMakeFiles/generate-internal-templated-content-ocp4.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....
[  1%] Built target generate-internal-fedora-shorthand.xml

[jhrozek]

Do we care about ^ ? Can't we just let RHEL-7 ride into the sunset?

[JAORMX]

Pull-request updated, HEAD is now e06bad6

[JAORMX]

Do we care about ^ ? Can't we just let RHEL-7 ride into the sunset?

I don't think we care much about those. But it seems to be a required test 😕 so we can't merge this as it is. Don't know how to move this forward.

[JAORMX]

Pull-request updated, HEAD is now 49ea5a6

[JAORMX]

Pull-request updated, HEAD is now 3d9e2d6

[JAORMX]

Pull-request updated, HEAD is now e06bad6

[JAORMX]

Pull-request updated, HEAD is now 473c767

[JAORMX]

Pull-request updated, HEAD is now 896385b

[jhrozek]

great, the python2 build passes now, ACK!