Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api_server_auth_mode_node rule to ocp4/cis profile #6195

Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 13, 2020

This rule checks that the authorization-mode is set to Node in the
api-server.

@redhatrises
Copy link
Contributor

@JAORMX Should applications/openshift/api-server/api_server_authorization_mode/rule.yml be fixed instead.

@dahaic
Copy link
Contributor

dahaic commented Oct 13, 2020

@JAORMX Should applications/openshift/api-server/api_server_authorization_mode/rule.yml be fixed instead.

Each of 1.2.7, 1.2.8 and 1.2.9 has its own specifics to check. Thus we have decided to go with three rules, and revert the api_server_authorization_mode back to OCP3 only. See #6209 where I am doing the revert.

This rule checks that the authorization-mode is set to Node in the
api-server.
@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 13, 2020

Pull-request updated, HEAD is now e01d571

@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 14, 2020

/retest

@redhatrises
Copy link
Contributor

/lgtm

@redhatrises redhatrises merged commit d0bd390 into ComplianceAsCode:master Oct 14, 2020
@yuumasato yuumasato added this to the 0.1.53 milestone Oct 27, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants