Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update api_server_audit_log_path to use different apiserver conf file. #6240

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Update api_server_audit_log_path to use different apiserver conf file. #6240

merged 2 commits into from
Oct 15, 2020

Conversation

ggbecker
Copy link
Member

Description:

  • Change api_server_audit_log_path to check for openshift-apiserver api configuration file.
  • Create a new rule to check the openshift-kube-apiserver namespace.

Rationale:

  • Currently we are checking only the openshift-kube-apiserver but we also need to check the openshift-apiserver namespace for some rules.
  • It looks like this PR is introducing something new and I don't know exactly we are going to handle these rules, if we are going to use the same group and such.

@ggbecker
Update api_server_audit_log_path to use different apiserver conf file.
062656d 
Create a new rule to check the openshift-kube-apiserver namespace.
JAORMX
JAORMX suggested changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure how to handle rules that should apply to the openshift-apiserver. Maybe we could have a group for those? called openshift-api-server

applications/openshift/api-server/api_server_audit_log_path/rule.yml Outdated Show resolved Hide resolved
ocp4/profiles/cis.profile Outdated Show resolved Hide resolved
@ggbecker ggbecker requested a review from JAORMX October 14, 2020 16:08
@JAORMX JAORMX merged commit cc58c42 into ComplianceAsCode:master Oct 15, 2020
@yuumasato yuumasato added this to the 0.1.53 milestone Oct 19, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX Awaiting requested review from JAORMX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.53
Development

Successfully merging this pull request may close these issues.
3 participants
@ggbecker @JAORMX @yuumasato