Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP4 CIS 5.2.5 (SCC privilege escalation) #6241

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

nkinder
Copy link
Contributor

@nkinder nkinder commented Oct 14, 2020

Description:

  • This adds a rule to check if SCC privilege escalation is disabled for at least one SCC.

Rationale:

  • This is required to satisfy CIS 5.2.5.

@openshift-ci-robot
Copy link
Collaborator

Hi @nkinder. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Used by openshift-ci bot. label Oct 14, 2020
@jhrozek
Copy link
Collaborator

jhrozek commented Oct 14, 2020

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Oct 14, 2020
Copy link
Collaborator

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule and the check look good. The default OCP4 installation is not compliant at the moment so I put a note to the draft CIS document that we need to follow up and see why even the restricted SCC doesn't prevent privilege escalation.

@jhrozek jhrozek merged commit cfcbb46 into ComplianceAsCode:master Oct 15, 2020
@yuumasato yuumasato added this to the 0.1.53 milestone Oct 19, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants