Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP4: Add e2e tests for rules in section 1.3 of the CIS benchmark #6320

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 30, 2020

These rules had been verified and this merely adds the expected defaults
to test for.

These rules had been verified and this merely adds the expected defaults
to test for.
@openscap-ci
Copy link
Collaborator

Show details

@JAORMX JAORMX requested a review from jhrozek October 30, 2020 11:46
The template didn't take into account a recent change that allows for
the entity_check to be included in the rule. So this fixed that.

It also added the missing OCIL clause.
@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 30, 2020

Pull-request updated, HEAD is now 393f25b

Copy link
Collaborator

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jhrozek jhrozek merged commit eb47bac into ComplianceAsCode:master Oct 30, 2020
@yuumasato yuumasato added this to the 0.1.53 milestone Nov 2, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants