Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocp4: Add automatic remediation for etcd encryption provider #6411

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Nov 23, 2020

Instead of this relying on a manual remediation, we should instead
create an automated one that the compliance-operator can deploy.

Depends on: openshift/compliance-operator#487

@JAORMX JAORMX changed the title ocp4: Add automatic remediation for etcd encryption provider WIP: ocp4: Add automatic remediation for etcd encryption provider Nov 23, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Nov 23, 2020
@redhatrises
Copy link
Contributor

@openscap-ci test this please

@redhatrises
Copy link
Contributor

/retest

@JAORMX
Copy link
Contributor Author

JAORMX commented Nov 25, 2020

@redhatrises we need to add extra permissions to the compliance-operator for this to work. The patch just merged, so now we just need to do an upstream release for it to get picked up here.

@redhatrises
Copy link
Contributor

/test e2e-aws-ocp4-cis

@JAORMX
Copy link
Contributor Author

JAORMX commented Nov 25, 2020

Still haven't done the upstream release. We're investigating some performance issues. I'll update here once that's done

@JAORMX JAORMX marked this pull request as draft November 26, 2020 12:08
@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 1, 2020

Pull-request updated, HEAD is now 589aabc

@JAORMX JAORMX marked this pull request as ready for review December 1, 2020 10:00
@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 1, 2020

/retest

@JAORMX JAORMX changed the title WIP: ocp4: Add automatic remediation for etcd encryption provider ocp4: Add automatic remediation for etcd encryption provider Dec 1, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Dec 1, 2020
@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 1, 2020

/test all

@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 1, 2020

/retest

1 similar comment
@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 1, 2020

/retest

Instead of this relying on a manual remediation, we should instead
create an automated one that the compliance-operator can deploy.
@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 1, 2020

Pull-request updated, HEAD is now 7b5809d

@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 2, 2020

/retest

@JAORMX JAORMX merged commit fe161d1 into ComplianceAsCode:master Dec 2, 2020
@yuumasato yuumasato added this to the 0.1.54 milestone Jan 12, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants