Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix remediations of ensure_logrotate_activated #6710

Merged
merged 3 commits into from
Mar 17, 2021
Merged

fix remediations of ensure_logrotate_activated #6710

merged 3 commits into from
Mar 17, 2021

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • fix regexes in Bash and Ansible remediation
  • fix regex in test

Rationale:

It turned out that regex was too strict and some occurences of "weekly / monthly / yearly" did not get removed properly.

@vojtapolasek vojtapolasek added bugfix Fixes to reported bugs. productization-issue Issue found in upstream stabilization process. labels Mar 16, 2021
@vojtapolasek vojtapolasek added this to the 0.1.55 milestone Mar 16, 2021
@openscap-ci
Copy link
Collaborator

Changes identified:
Rules:
 ensure_logrotate_activated

Show details

Rule ensure_logrotate_activated:
 Ansible remediation changed.
 Found change in bash remediation.

Recommended tests to execute:
 build_product rhel8
 tests/test_suite.py rule --libvirt qemu:///system test-suite-vm --remediate-using ansible --datastream build/ssg-rhel8-ds.xml ensure_logrotate_activated
 tests/test_suite.py rule --libvirt qemu:///system test-suite-vm --remediate-using bash --datastream build/ssg-rhel8-ds.xml ensure_logrotate_activated

@openshift-ci
Copy link

openshift-ci bot commented Mar 16, 2021

@vojtapolasek: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-ocp4-cis-node d7e3988 link /test e2e-aws-ocp4-cis-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuumasato yuumasato self-assigned this Mar 17, 2021
yuumasato
yuumasato approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yuumasato yuumasato merged commit ddaad85 into ComplianceAsCode:master Mar 17, 2021
vojtapolasek pushed a commit that referenced this pull request Mar 17, 2021
@yuumasato @vojtapolasek
Merge pull request #6710 from vojtapolasek/fix_ensure_logrotate_activ…
cc66156 
…ated_remediation

fix remediations of ensure_logrotate_activated

(cherry picked from commit ddaad85)
@vojtapolasek vojtapolasek added the backported-into-stabilization PRs which were cherry-picked during stabilization process. label Mar 17, 2021
@ggbecker ggbecker mentioned this pull request Mar 23, 2021
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuumasato yuumasato yuumasato approved these changes

Assignees

@yuumasato yuumasato

Labels
backported-into-stabilization PRs which were cherry-picked during stabilization process. bugfix Fixes to reported bugs. productization-issue Issue found in upstream stabilization process.
Projects
None yet
Milestone
0.1.55
Development

Successfully merging this pull request may close these issues.
3 participants
@vojtapolasek @openscap-ci @yuumasato