rhcos4: Add check for nousb kernel argument #6743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes identified: Show detailsProfile moderate on rhcos4: Recommended tests to execute: |
ggbecker
reviewed
Mar 23, 2021
There was a problem hiding this comment.
Since you are making the template parameter optional, you can update the documentation as well here: https://github.com/ComplianceAsCode/content/blame/master/docs/manual/developer/06_contributing_with_content.md#L1279
ggbecker
reviewed
Mar 23, 2021
|
/test e2e-aws-ocp4-moderate |
|
/test e2e-aws-ocp4-moderate |
|
@ggbecker I think this is good to go, can you revisit this? |
ggbecker
reviewed
Mar 24, 2021
ggbecker
requested changes
Mar 24, 2021
This adds a check that verifies if the nousb kernel argument is set. If it isn't it should generate an appropraite remediation. This also enhances the `coreos_kernel_option` template and the `oval_argument_value_in_line_criterion` and `oval_argument_value_in_line_test` macros to not require `arg_value` anymore. If this parameter is not given, it'll only use `arg_name`. Signed-off-by: Juan Antonio Osorio Robles <jaosorior@redhat.com>
ggbecker
reviewed
Mar 24, 2021
ggbecker
approved these changes
Mar 24, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check that verifies if the nousb kernel argument is set. If
it isn't it should generate an appropraite remediation.
This also enhances the
coreos_kernel_optiontemplate and theoval_argument_value_in_line_criterionandoval_argument_value_in_line_testmacros to not requirearg_valueanymore. If this parameter is not given, it'll only use
arg_name.Signed-off-by: Juan Antonio Osorio Robles jaosorior@redhat.com