Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service_nfs_disabled - change name of nfs service to nfs-server #6777

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Mar 30, 2021

Description:

There is no nfs service in rhel8 nor in Fedora. The service is called nfs-server.
In rhel7, the nfs service exists but it is actually the same as nfs-server:

[root@localhost ~]# systemctl status nfs
● nfs-server.service - NFS server and services
   Loaded: loaded (/usr/lib/systemd/system/nfs-server.service; disabled; vendor preset: disabled)
...

[root@localhost ~]# systemctl status nfs-server
● nfs-server.service - NFS server and services
   Loaded: loaded (/usr/lib/systemd/system/nfs-server.service; disabled; vendor preset: disabled)
...

Unfortunately, I don't have sle15 so I can't check the service there. However, in the sle15 documentation, nfs service is mentioned.

@ggbecker
Copy link
Member

Unfortunately, I don't have sle15 so I can't check the service there. However, in the sle15 documentation, nfs service is mentioned.

@brett060102 FYI, you may want to double-check if the service name nfs exists in SLE15

@JAORMX
Copy link
Contributor

JAORMX commented Mar 31, 2021

/retest

OpenShift CI failed executing the test gathering pods:

 2021/03/31 10:33:09 Container sidecar in pod e2e-aws-ocp4-cis-gather-aws-console completed successfully
The connection to the server api.ci-op-pc0bj54t-1d877.origin-ci-int-aws.dev.rhcloud.com:6443 was refused - did you specify the right host or port?
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-03-31T10:33:08Z"} 

This is a flake in the CI infra and is unrelated to this PR.

@brett060102
Copy link
Contributor

brett060102 commented Mar 31, 2021

nfs service also exists in SUSE SLE-15 as an alias to nfs-server.

@brett060102
Copy link
Contributor

This rule is not used for SUSE SLE-15. The sle15 was added to the prodtype before I started on this project, but I have checked our published STIGS and we don't have associated with nfs server/export. So, the "{{% if product == "sle15" %}}" checks are not needed.

@mildas
Copy link
Contributor Author

mildas commented Mar 31, 2021

@brett060102 Great, thanks for the information. Can I remove the sle15 from prodtype?

@brett060102
Copy link
Contributor

@mildas yes, that would be fine.

@mildas
Copy link
Contributor Author

mildas commented Apr 6, 2021

@brett060102 CaC build failed and I have noticed that the service_nfs_disabled rule is actually used in sle15 - in CIS profile. Please verify, that it's expected and I will add the product and conditions back.

@brett060102
Copy link
Contributor

Looking.

@brett060102
Copy link
Contributor

#6803 should fix the issue.

@yuumasato
Copy link
Member

I'm not sure why the conflict happens.
@mildas Can you rebase?

@mildas
Copy link
Contributor Author

mildas commented Apr 12, 2021

@yuumasato There were some strange conflicts with ocil but it should be fine now.

@yuumasato yuumasato self-assigned this Apr 12, 2021
@yuumasato yuumasato merged commit 96271f9 into ComplianceAsCode:master Apr 12, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants