Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Until now the rule was focused mainly on /etc/profile. However, editing /etc/profile directly is not a good practice anymore. We should rather modify some file within /etc/profile.d/ directory.
This PR also extends tests to cover all capabilities of check and remediations. Before we were testing only for correct check / remediation of /etc/profile, although /etc/profile.d/*.sh was covered too.
This PR addresses main concerns of #6746 . I am hesitant to remove references to /etc/profile entirely.