-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing references test #6849
Missing references test #6849
Conversation
I will split this PR into two PRs - this one will add only the test and the new PR will add it to |
Have you considered making this an CMake macro instead of a bash script to avoid having multiple abstraction levels? |
@jan-cerny No. Actually, I didn't think about CMake macro approach at all because it didn't occur to me. |
I think it would be readable
That's a good argument against it. |
@jan-cerny What do you think? Should I implement it as CMake macro or are you fine with current approach? |
@mildas I'm fine with either way. |
@mildas: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jan-cerny PR is updated. Bash script will be better because the script will be also used in daily Jenkins job to check all profiles. |
Description:
Add test for checking missing references in profiles.
Usage:
$ tests/missing_refs.sh python3 build/ssg-rhel8-xccdf.xml ospp stig hipaa
$1 - python executable (for cmake,
${PYTHON_EXECUTABLE}
)$2 - product xccdf
$3+ - list of profiles
Rationale:
Test that will be added to gating.