Prioritize install_smartcard_packages like package_*_installed #7224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @cipherboy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-08 19:25:12 UTC |
Several smartcard rules have the problem that install_smartcard_packages is not appropriately ordered. In ComplianceAsCode#7208, we renamed the rule to match the pattern of package_*_installed. However, this approach breaks any existing tailoring and thus wasn't desired. Move to updating the Python to order this rule as a special case. Signed-off-by: Alexander Scheel <alex.scheel@canonical.com>
Signed-off-by: Alexander Scheel <alex.scheel@canonical.com>
cipherboy
force-pushed
the
fix-smartcard-ordering
branch
from
a7b0878
to
87be8d3
Compare
matejak
approved these changes
Jul 14, 2021
vojtapolasek
pushed a commit
that referenced
this pull request
Jul 16, 2021
Prioritize install_smartcard_packages like package_*_installed (cherry picked from commit 13a88c7)
vojtapolasek
added
backported-into-stabilization
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Several smartcard rules have the problem that install_smartcard_packages
is not appropriately ordered. In #7208, we renamed the rule to match the
pattern of package_*_installed. However, this approach breaks any
existing tailoring and thus wasn't desired. Move to updating the Python
to order this rule as a special case.
Signed-off-by: Alexander Scheel <alex.scheel@canonical.com>