Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ansible remediation of display_login_attempts #7271

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Fix ansible remediation of display_login_attempts #7271

merged 1 commit into from
Jul 22, 2021

Conversation

ggbecker
Copy link
Member

Description:

  • Fix ansible remediation of display_login_attempts.

@ggbecker ggbecker added the Ansible Ansible remediation update. label Jul 22, 2021
@ggbecker ggbecker added this to the 0.1.57 milestone Jul 22, 2021
@vojtapolasek vojtapolasek self-assigned this Jul 22, 2021
vojtapolasek
vojtapolasek approved these changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the fix works, verified manually on clean rhel installation. However, the added test scenario does not display error when tested with previous implementation... so maybe we are not testing the right thing. But I have no idea why it is like that.
I will merge the fix, as it clearly improves the experience.

@vojtapolasek vojtapolasek merged commit d13de01 into ComplianceAsCode:master Jul 22, 2021
@ggbecker
Copy link
Member Author

ggbecker commented Jul 22, 2021 •
edited
Loading

Thank you, the fix works, verified manually on clean rhel installation. However, the added test scenario does not display error when tested with previous implementation... so maybe we are not testing the right thing. But I have no idea why it is like that.

I had the same behavior and don't why I can't reproduce it. But the file should be the same as in RHEL7 vanilla.

I will merge the fix, as it clearly improves the experience.

vojtapolasek added a commit that referenced this pull request Jul 22, 2021
@vojtapolasek
Merge pull request #7271 from ggbecker/fix-display-login-attemps-ansible
5487fbd 
Fix ansible remediation of display_login_attempts

(cherry picked from commit d13de01)
@vojtapolasek vojtapolasek added backported-into-stabilization PRs which were cherry-picked during stabilization process. bugfix Fixes to reported bugs. labels Jul 22, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtapolasek vojtapolasek vojtapolasek approved these changes

Assignees

@vojtapolasek vojtapolasek

Labels
Ansible Ansible remediation update. backported-into-stabilization PRs which were cherry-picked during stabilization process. bugfix Fixes to reported bugs.
Projects
None yet
Milestone
0.1.57
Development

Successfully merging this pull request may close these issues.
2 participants
@ggbecker @vojtapolasek