Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sort prodtypes to fix_rules #7454

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Add sort prodtypes to fix_rules #7454

merged 2 commits into from
Sep 2, 2021

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Aug 24, 2021

Description:

This adds sort_prodtypes to ./utils/fix_rules. This ensures that prodtypes are in alphabetical order.

Rationale:

To help make the rule files easier to read.

@Mab879 Mab879 added enhancement General enhancements to the project. Infrastructure Our content build system labels Aug 24, 2021
@Mab879 Mab879 added this to the 0.1.58 milestone Aug 24, 2021
@Mab879 Mab879 force-pushed the add_sort_prodtypes branch 4 times, most recently from 0ee0784 to e8e4a56 Compare August 24, 2021 18:50
@matejak
Copy link
Member

matejak commented Aug 26, 2021

Could you perhaps merge #7249 first and then rebase this PR on top of it? That PR removes some of the boilerplate.

@matejak matejak self-assigned this Aug 26, 2021
@Mab879
Copy link
Member Author

Mab879 commented Aug 26, 2021

@matejak I have merged #7249 and rebase my changes on that.

cipherboy
cipherboy reviewed Aug 28, 2021
View reviewed changes
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits.

utils/fix_rules.py Outdated Show resolved Hide resolved
utils/fix_rules.py Show resolved Hide resolved
utils/fix_rules.py Outdated Show resolved Hide resolved
utils/fix_rules.py Outdated Show resolved Hide resolved
@Mab879 Mab879 force-pushed the add_sort_prodtypes branch 2 times, most recently from fb277ab to 377ed09 Compare August 30, 2021 17:14
@pep8speaks
Copy link

pep8speaks commented Aug 30, 2021 •
edited
Loading

Hello @Mab879! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-31 15:57:45 UTC

@Mab879 Mab879 requested a review from matejak August 30, 2021 17:16
@Mab879
Add sort_prodtypes to fix_rules
bb06d7a 
This ensure that products in prodtype are in alphabetical order.
@Mab879
Automatically sorted prodtypes
7e0de6d
matejak
matejak approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@matejak matejak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, works for me, many thanks!

@matejak matejak merged commit 4d9feaf into ComplianceAsCode:master Sep 2, 2021
@cipherboy cipherboy mentioned this pull request Sep 7, 2021
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipherboy cipherboy cipherboy left review comments

@matejak matejak matejak approved these changes

Assignees

@matejak matejak

Labels
enhancement General enhancements to the project. Infrastructure Our content build system
Projects
None yet
Milestone
0.1.58
Development

Successfully merging this pull request may close these issues.
4 participants
@Mab879 @matejak @pep8speaks @cipherboy