-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test scenarios specific for CIS #7634
Add test scenarios specific for CIS #7634
Conversation
This commit adds test scenarios specific for the RHEL7 CIS Level 2 profile for rules accounts_password_pam_pwhistory_remember_system_auth and accounts_password_pam_pwhistory_remember_password_auth. The test scenarios were copied from existing correct value pass scenario and the values have been set according to item 5.4.4 in controls/cis_rhel7.yml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for well commented tests.
See comments.
Actually @matusmarhefka doers it make sense to add remaining CIS profiles? Does it make sense when testing for example in profile mode in SSG test suite?
#!/bin/bash | ||
# packages = pam | ||
# platform = Red Hat Enterprise Linux 7 | ||
# profiles = xccdf_org.ssgproject.content_profile_cis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add remaining cis profiles?
#!/bin/bash | ||
# packages = pam | ||
# platform = Red Hat Enterprise Linux 7 | ||
# profiles = xccdf_org.ssgproject.content_profile_cis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add also remaining cis profiles?
Test scenarios are only executed in rule/combined mode. I think in this case it is enough to have just |
The new name emphasises that the scenario is only for RHRL 7 CIS.
Description:
This commit adds test scenarios specific for the RHEL7 CIS Level 2
profile for rules accounts_password_pam_pwhistory_remember_system_auth
and accounts_password_pam_pwhistory_remember_password_auth. The test
scenarios were copied from existing correct value pass scenario
and the values have been set according to item 5.4.4 in
controls/cis_rhel7.yml.
Rationale:
Increase test coverage of CIS profile.