Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NERC CIP profiles for OCP4 and RHCOS #7757

Merged
merged 6 commits into from
Oct 18, 2021

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 18, 2021

This adds relevant profiles which merely extend our current moderate profiles.

It has been identified that the NERC CIP requirements can be met by the NIST
moderate requirements, so let's add this and via that extension we can make
sure they stay updated.

This also:

  • Updates CIP-009-3 references to CIP-009-6
  • Updates CIP-005-3a references to CIP-005-6
  • Updates CIP-004-3 references to CIP-004-6
  • Updates CIP-003-3 references to CIP-003-8
  • Updates CIP-002-3 references to CIP-002-5

As the CIP profiles have been updated and the references hadn't.

CIP 002 was updated and we should be using the newer revision.

Signed-off-by: Juan Antonio Osorio Robles <jaosorior@redhat.com>
CIP 003 was updated and we should be using the newer revision.

Signed-off-by: Juan Antonio Osorio Robles <jaosorior@redhat.com>
Signed-off-by: Juan Antonio Osorio Robles <jaosorior@redhat.com>
@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 18, 2021

Pull-request updated, HEAD is now fbc232b

These profiles extend the moderate ones.

Signed-off-by: Juan Antonio Osorio Robles <jaosorior@redhat.com>
@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 18, 2021

Pull-request updated, HEAD is now 840704a

Copy link
Collaborator

@mrogers950 mrogers950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2021

@JAORMX: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp4-pci-dss-node 840704a link true /test e2e-aws-ocp4-pci-dss-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This /lgtm

@JAORMX JAORMX merged commit a177364 into ComplianceAsCode:master Oct 18, 2021
@Mab879 Mab879 added this to the 0.1.59 milestone Nov 12, 2021
@yuumasato yuumasato added New Profile Issues or pull requests related to new Profiles. Highlight This PR/Issue should make it to the featured changelog. labels Nov 26, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Highlight This PR/Issue should make it to the featured changelog. New Profile Issues or pull requests related to new Profiles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants