Add the ability to load controls from folder #7876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help control the length of the control files
jan-cerny
reviewed
Nov 15, 2021
| yaml_contents = ssg.yaml.open_and_expand(full_path, self.env_yaml) | ||
| controls_tree.append(yaml_contents) | ||
| else: | ||
| raise RuntimeError("Found non yaml file in %s" % self.controls_dir) |
There was a problem hiding this comment.
maybe skip vim swap files and other temporary files
jan-cerny
approved these changes
Nov 16, 2021
| - var_accounts_tmout=10_min | ||
| - configure_crypto_policy | ||
| notes: >- | ||
| Certain period of inactivity is vague. |
There was a problem hiding this comment.
There should be newline at the end of the file.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Loads controls from files matching
controls/control_file/*.yml.Rationale:
To help control the length of the control files.