Add better error messages to utils/controleval.py and add does not meet to stats output #8038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-cerny
reviewed
Jan 10, 2022
Adds an error message for the case when the a policy has a level defined but has no controls. This commit also adds the 'does not meet' to the stats output.
Mab879
force-pushed
the
add_does_not_meet_to_contorleval
branch
from
56d9bb3
to
68bf173
Compare
jan-cerny
approved these changes
Jan 10, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds an error message for the case when the a policy has a level
defined but has no controls. This commit also adds the 'does not meet'
to the stats output
Rationale:
Before the script would give an divide by zero error. Also, added a new status to the script to aid in creating control files.