New sysctl fs parameters #8304
Merged
New sysctl fs parameters #8304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New parameter available on kernel > 4.19
|
Start a new ephemeral environment with changes proposed in this pull request: |
marcusburghardt
force-pushed
the
sysctl_fs
branch
from
b374f16
to
5a9b614
Compare
marcusburghardt
added
New Rule
|
I have to investigate why the |
New parameter available on kernel > 4.19
marcusburghardt
force-pushed
the
sysctl_fs
branch
from
5a9b614
to
fac6bed
Compare
marcusburghardt
removed
the
do-not-merge/work-in-progress
|
/retest |
|
@marcusburghardt: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
jan-cerny
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
[jcerny@thinkpad scap-security-guide{pr/8304}]$ python3 tests/test_suite.py rule --libvirt qemu:///system ssgts_rhel9 sysctl_fs_protected_fifos sysctl_fs_protected_regular
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2022-03-10-1033/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_sysctl_fs_protected_fifos
INFO - Script expected_value.pass.sh using profile (all) OK
INFO - Script missing_parameter.fail.sh using profile (all) OK
INFO - Script unexpected_value.fail.sh using profile (all) OK
[jcerny@thinkpad scap-security-guide{pr/8304}]$ python3 tests/test_suite.py rule --libvirt qemu:///system ssgts_rhel9 sysctl_fs_protected_regular
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2022-03-10-1035/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_sysctl_fs_protected_regular
INFO - Script expected_value.pass.sh using profile (all) OK
INFO - Script missing_parameter.fail.sh using profile (all) OK
INFO - Script unexpected_value.fail.sh using profile (all) OK
| {{% endif %}} | ||
| <criteria operator="AND"> | ||
| <extend_definition comment="{{{ SYSCTLVAR }}} configuration setting check" definition_ref="sysctl_static_{{{ SYSCTLID }}}" /> | ||
| <extend_definition comment="{{{ SYSCTLVAR }}} runtime setting check" definition_ref="sysctl_runtime_{{{ SYSCTLID }}}" /> | ||
| <extend_definition comment="{{{ SYSCTLVAR }}} configuration setting check" |
There was a problem hiding this comment.
We usually don't do changes just because of formatting or whitespace.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since kernel 4.19, new parameters were introduced to permit a better access control to regular files and FIFOs.
This PR adds two new rules for these parameters.