Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new GH job to generate XLSX table and HTML page with SRG mapping #8326

Merged
merged 6 commits into from
Apr 12, 2022
Merged

Add new GH job to generate XLSX table and HTML page with SRG mapping #8326

merged 6 commits into from
Apr 12, 2022

Conversation

ggbecker
Copy link
Member

@ggbecker ggbecker commented Mar 10, 2022 •
edited
Loading

Description:

  • Add new GH job to generate XLSX table and HTML page with SRG mapping

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Mar 10, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Open in Gitpod

@ggbecker ggbecker force-pushed the csv-gh-job branch 2 times, most recently from 530b3e8 to 7906676 Compare March 10, 2022 17:56
@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2022

@ggbecker: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp4-high 7906676 link true /test e2e-aws-ocp4-high

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Mab879
Mab879 reviewed Mar 25, 2022
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea and will be helpful in the RHEL9 STIG development.

utils/create_srg_export.py Outdated Show resolved Hide resolved
@pep8speaks
Copy link

pep8speaks commented Apr 11, 2022 •
edited
Loading

Hello @ggbecker! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-04-12 11:58:43 UTC

@ggbecker ggbecker changed the title WIP: Add new GH job to generate CSV table and HTML page with SRG mapping WIP: Add new GH job to generate XLSX table and HTML page with SRG mapping Apr 11, 2022
@ggbecker ggbecker changed the title WIP: Add new GH job to generate XLSX table and HTML page with SRG mapping Add new GH job to generate XLSX table and HTML page with SRG mapping Apr 11, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 11, 2022
@ggbecker
Copy link
Member Author

@Mab879 FYI

@Mab879 Mab879 self-assigned this Apr 11, 2022
@Mab879 Mab879 added this to the 0.1.62 milestone Apr 11, 2022
@Mab879 Mab879 added the Infrastructure Our content build system label Apr 11, 2022
Mab879
Mab879 requested changes Apr 11, 2022
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the direction of script.

Can you take a look at the PEP8 errors?

@ggbecker ggbecker linked an issue Apr 11, 2022 that may be closed by this pull request
The SRG Export Script should HTML output in CI #8518
Closed
Mab879
Mab879 reviewed Apr 11, 2022
View reviewed changes
utils/create_srg_export.py Outdated Show resolved Hide resolved
@ggbecker
Copy link
Member Author

I haven't tested the files publishing as I can't do it without actually pushing to master, so there might be needed some extra rounds of commits to fix any issue that may appear in the gh-pages deployment

@Mab879 Mab879 merged commit d5a7034 into ComplianceAsCode:master Apr 12, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
Infrastructure Our content build system
Projects
None yet
Milestone
0.1.62
Development

Successfully merging this pull request may close these issues.

The SRG Export Script should HTML output in CI
3 participants
@ggbecker @pep8speaks @Mab879