Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements for file permission and ownership templates #8456

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Performance improvements for file permission and ownership templates #8456

merged 3 commits into from
Mar 30, 2022

Commits on Mar 29, 2022

  1. Performance improvements for file_owner template 

    This template used to hit performance issues when directories were
recursively assessed. The OVAL logic was slightly changed to improve the
performance around 50% or more for some rules.
    @marcusburghardt
    marcusburghardt committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    ee51878 View commit details
    Browse the repository at this point in the history

  2. Performance improvements for file_groupowner template 

    Like file_owner template, file_groupowner was also prone to hit performance
issues when directories were recursively assessed. The OVAL logic was slightly
changed to increase the performance for some rules.
    @marcusburghardt
    marcusburghardt committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    54fd22f View commit details
    Browse the repository at this point in the history

  3. Change the file_permissions template to improve performance 

    OVAL assessment was working with include filter to collect file objects
and in a second step, checking these objects against a file state. This
approach was collecting all file objects regardless of their permissions.
This means that many objects may be evaluated unnecessarily.

The logic was changed to exclude already compliant files from the file
objects list. The permission check itself is expensive, limiting the
performance gain. Even so the performance was slightly improved.
    @marcusburghardt
    marcusburghardt committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    670bae0 View commit details
    Browse the repository at this point in the history