Update SRG-OS-000114-GPOS-00059 for RHEL 9 STIG #8505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: |
|
This datastream diff is auto generated by the check Click here to see the full diffOCIL for rule 'xccdf_org.ssgproject.content_rule_service_autofs_disabled' differs:
--- old datastream
+++ new datastream
@@ -20,5 +20,5 @@
LoadState=masked
UnitFileState=masked
- Is it the case that ?
+ Is it the case that the autofs service is not disabled?
New datastream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_usbguard_allow_hid'.
New datastream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_usbguard_allow_hid_and_hub'.
New datastream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_usbguard_allow_hub'. |
Mab879
added
RHEL9
Mab879
reviewed
Apr 7, 2022
linux_os/guide/system/permissions/mounting/kernel_module_usb-storage_disabled/rule.yml
Outdated
Show resolved
Hide resolved
...guide/system/software/gnome/gnome_media_settings/dconf_gnome_disable_automount_open/rule.yml
Outdated
Show resolved
Hide resolved
linux_os/guide/system/software/gnome/gnome_media_settings/dconf_gnome_disable_autorun/rule.yml
Outdated
Show resolved
Hide resolved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
jan-cerny
force-pushed
the
SRG-OS-000114-GPOS-00059
branch
from
d2e7e18
to
0bb0184
Compare
|
I have rebased this pull request on the top of the currrent master branch and I have replaced fix by fixtext and resolved conflict with moving Jinja macro to a different file. |
|
/retest |
Mab879
requested changes
Apr 19, 2022
linux_os/guide/system/permissions/mounting/service_autofs_disabled/rule.yml
Outdated
Show resolved
Hide resolved
Mab879
previously approved these changes
Apr 20, 2022
|
/retest |
|
@jan-cerny Can you take look a the merge conflict? |
jan-cerny
force-pushed
the
SRG-OS-000114-GPOS-00059
branch
from
ec869a1
to
7b882c4
Compare
|
/retest |
|
Hi, it's now rebased again. |
|
/retest |
1 similar comment
|
/retest |
|
So those OpenShift CI errors are giving me some pause before I merged them. @rhmdnd or @Vincent056 I think these failures might be valid, can you please confirm? |
jan-cerny
force-pushed
the
SRG-OS-000114-GPOS-00059
branch
from
3657e29
to
22db548
Compare
|
I have resolved the conflict and I have rebased on the top of the latest upstream branch. |
|
/retest |
|
Since #8564 has just merged, the test should pass once this PR rebase. |
It wasn't aligned with the bash remediations because it doesn't contain the step to add a lock to /etc/dconf/db/local.d/locks/00-security-settings-lock whereas the bash remediation adds the lock. An exception is rule gnome_gdm_disable_automatic_login. Therefore I changed the dconf_ini_file_fix macro so that it looks similar to fix text in the dconf_gnome_disable_automount_open rule, use it in every dconf settings and replace its use in fix in the rule gnome_gdm_disable_automatic_login with a different fix text.
jan-cerny
force-pushed
the
SRG-OS-000114-GPOS-00059
branch
from
22db548
to
a90a794
Compare
|
I have rebased on the top of the latest upstream branch. |
|
/retest |
Mab879
approved these changes
May 2, 2022
|
Waving SSGTS, the tests pass locally. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
adds fix texts, Ansible remediations, fixes OCIL
Rationale:
RHEL 9 STIG