Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUSE disable_users_coredumps enable bash remediation for sle. #8558

Merged

Conversation

brett060102
Copy link
Contributor

sle system were supported for ansible remediation through
platform = multi_platform_all

But not for bash, which had:

so just added multi_platform_sle to the platform list in
disable_users_coredumps/bash/shared.sh

Description:

  • Enable bash remediation for sle systems in disable_users_coredumps enable

Rationale:

  • Parity between bash and ansible remediations

sle system were supported for ansible remediation through
platform = multi_platform_all

But not for bash, which had:

so just added multi_platform_sle  to the platform list in
disable_users_coredumps/bash/shared.sh
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2022

Hi @brett060102. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Open in Gitpod

@Mab879
Copy link
Member

Mab879 commented Apr 14, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 14, 2022
@vojtapolasek vojtapolasek self-assigned this Apr 14, 2022
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vojtapolasek vojtapolasek added Bash Bash remediation update. SLES SUSE Linux Enterprise Server product related. labels Apr 14, 2022
@vojtapolasek vojtapolasek added this to the 0.1.62 milestone Apr 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2022

@brett060102: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-high 06ca253 link true /test e2e-aws-rhcos4-high
ci/prow/e2e-aws-rhcos4-moderate 06ca253 link true /test e2e-aws-rhcos4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vojtapolasek vojtapolasek merged commit 3c4eb2c into ComplianceAsCode:master Apr 19, 2022
@brett060102 brett060102 deleted the SUSE_disable_users_coredumps branch June 28, 2023 20:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update. ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants