Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point the docs to new jinja macro files #8577

Merged

Conversation

yuumasato
Copy link
Member

Description:

  • Update Jinja doc references.

Rationale:

@yuumasato yuumasato added bugfix Fixes to reported bugs. Documentation Update in project documentation. labels Apr 19, 2022
@yuumasato yuumasato added this to the 0.1.62 milestone Apr 19, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Open in Gitpod

@ggbecker
Copy link
Member

the PR fixes the issue the doc build but I still see some references of the highlevel.jinja file for example:
https://github.com/ComplianceAsCode/content/blame/master/docs/manual/developer/06_contributing_with_content.md#L369-L388

@yuumasato yuumasato requested a review from ggbecker April 19, 2022 15:43
@@ -395,6 +387,8 @@ specified, and they depend on each other. Macros that begin with
make sure that OCIL and OCIL clauses are defined and consistent. Macros
that begin with underscores are not meant to be used in descriptions.

You can check documentation for all macros in the [Jinja Macros Reference section](../../index.html#jinja-macros-reference).
Copy link
Member

@ggbecker ggbecker Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this type of reference doesn't work when the content is built by readthedocs and I was not able to find a workaround for that similar as the deleted line 388

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a lot of references in https://complianceascode.readthedocs.io/en/latest/manual/developer/03_creating_content.html with the same syntax are broken.

Copy link
Member Author

@yuumasato yuumasato Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rewritten the paragraph to remove the broken reference link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a lot of references in https://complianceascode.readthedocs.io/en/latest/manual/developer/03_creating_content.html with the same syntax are broken.

these come when we did the conversion from .adoc to .md and when we hosted in github. Those we can easily fix by changing to the actual file in the github project.

The references with local reference don't work on Read the Docs.
@ggbecker ggbecker self-assigned this Apr 20, 2022
@ggbecker ggbecker merged commit fe68fcd into ComplianceAsCode:master Apr 20, 2022
@yuumasato yuumasato deleted the fix_docs_build_after_macro_reorg branch April 20, 2022 09:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. Documentation Update in project documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants