Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set pipefail in Ansible shell commands with pipe #9123

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Set pipefail in Ansible shell commands with pipe #9123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
170cb3d
Set pipefail in Ansible shell commands with pipe
yuumasato Jul 11, 2022
855ff16
Mark tasks that don't make changes
yuumasato Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions ...ogging/ensure_rsyslog_log_file_configuration/rsyslog_files_permissions/ansible/shared.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,32 @@
# * And also the log file paths listed after rsyslog's $IncludeConfig directive
# (store the result into array for the case there's shell glob used as value of IncludeConfig)
- name: "Get IncludeConfig directive"
shell: grep -e '$IncludeConfig' {{ rsyslog_etc_config }} | cut -d ' ' -f 2
shell: |
set -o pipefail
grep -e '$IncludeConfig' {{ rsyslog_etc_config }} | cut -d ' ' -f 2 || true
register: include_config_output
changed_when: False

- name: "Get include files directives"
shell: grep -oP '^\s*include\s*\(\s*file.*' {{ rsyslog_etc_config }} |cut -d"\"" -f 2
shell: |
set -o pipefail
grep -oP '^\s*include\s*\(\s*file.*' {{ rsyslog_etc_config }} |cut -d"\"" -f 2 || true
register: include_files_output
changed_when: False

- name: "List all config files"
shell: find "$(dirname "{{ item }}" )" -maxdepth 1 -name "$(basename "{{ item }}")"
loop: "{{ include_config_output.stdout_lines + include_files_output.stdout_lines }}"
register: rsyslog_config_files
changed_when: False

- name: "Extract log files"
shell: grep -oP '^[^(\s|#|\$)]+[\s]+.*[\s]+-?(/+[^:;\s]+);*\.*$' {{ item }} |awk '{print $NF}'|sed -e 's/^-//'
shell: |
set -o pipefail
grep -oP '^[^(\s|#|\$)]+[\s]+.*[\s]+-?(/+[^:;\s]+);*\.*$' {{ item }} |awk '{print $NF}'|sed -e 's/^-//'
loop: "{{ rsyslog_config_files.results|map(attribute='stdout_lines')|list|flatten|unique + [ rsyslog_etc_config ] }}"
register: log_files
changed_when: False

- name: "Setup log files permissions"
ignore_errors: yes
Expand Down