Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make audit AArch64 specific rules RHEL9 only #9188

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • change prodtype to rhel9 and return back rhel8 CCEs
  • for non-aarch64 rules, in case of rhel9, make them not applicable so that they do not override each other
  • remove rules from rhel8 profile

Rationale:

Architecture specific audit files are not present on RHEL8.

@vojtapolasek vojtapolasek added RHEL9 Red Hat Enterprise Linux 9 product related. Update Rule Issues or pull requests related to Rules updates. Update Profile Issues or pull requests related to Profiles updates. RHEL8 Red Hat Enterprise Linux 8 product related. OSPP OSPP benchmark related. labels Jul 20, 2022
@vojtapolasek vojtapolasek added this to the 0.1.64 milestone Jul 20, 2022
@vojtapolasek vojtapolasek requested a review from a team as a code owner July 20, 2022 08:41
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@ggbecker
Copy link
Member

changed the milestone to 0.1.63 as this PR is going to be in the stabilization branch as well.

@jan-cerny jan-cerny self-assigned this Jul 25, 2022
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good but please resolve the conflicts.

@vojtapolasek vojtapolasek force-pushed the audit_aarch64_rules_rhel9_only_master branch from 1cad33a to b948fa8 Compare July 25, 2022 15:13
@vojtapolasek
Copy link
Collaborator Author

@jan-cerny I rebased and conflicts should be fixed.

@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2022

@vojtapolasek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-moderate b948fa8 link true /test e2e-aws-rhcos4-moderate
ci/prow/e2e-aws-rhcos4-high b948fa8 link true /test e2e-aws-rhcos4-high
ci/prow/e2e-aws-rhcos4-e8 b948fa8 link true /test e2e-aws-rhcos4-e8

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codeclimate
Copy link

codeclimate bot commented Jul 25, 2022

Code Climate has analyzed commit b948fa8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny merged commit cc87082 into ComplianceAsCode:master Jul 26, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OSPP OSPP benchmark related. RHEL8 Red Hat Enterprise Linux 8 product related. RHEL9 Red Hat Enterprise Linux 9 product related. Update Profile Issues or pull requests related to Profiles updates. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants