-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move kernel_module_disabled use more genric RHEL in conditionals #9450
Conversation
Listing versions causes issues when we release a new version of RHEL.
You say that it fixes #9192 . It fixes for me the problem with kernel_module_can_disabled on RHEL 9, but it doesn't fix the problem with kernel_module_dccp_disabled on RHEL 7. Is it an omission or do the test for RHEL 7 pass on your system?
|
Code Climate has analyzed commit 2bd830e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 40.4% (-1.8% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, it works for me on both rhel 7 and 9.
Description:
This PR changes the conditions in
kernel_module_disabled
to useproduct in 'rhel'
vsif product in ['rhel7, 'rhel8']
.Rationale:
Listing versions causes issues when we release a new version of RHEL.
Fixes #9192