Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules for RHEL 9 STIG #9512

Merged
merged 55 commits into from
Sep 20, 2022
Merged

Conversation

jan-cerny
Copy link
Collaborator

Description:

According to feedback from DISA we updated some rules and their OCIL, fixtext, SRG requirements, etc.

Rationale:

Update the rules for RHEL 9 STIG.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; I left a few comments throughout.

@jan-cerny
Copy link
Collaborator Author

I have tried to address the feedback in the new commits.

@vojtapolasek vojtapolasek modified the milestones: 0.1.64, 0.1.65 Sep 19, 2022
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change is requested so that we don't lose some work.

@@ -65,5 +65,3 @@ fixtext: |-
Remove accounts that do not support approved system activities or that allow for a normal user to perform administrative-level actions.

Document all authorized accounts on the system.

srg_requirement: '{{{ full_name }}} must not have unnecessary accounts.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive that this should still be here.

@jan-cerny
Copy link
Collaborator Author

I have add back SRG requirement to accounts_authorized_local_users.

@codeclimate
Copy link

codeclimate bot commented Sep 20, 2022

Code Climate has analyzed commit a51d10e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 40.4% (0.0% change).

View more on Code Climate.

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

@jan-cerny: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-moderate a51d10e link true /test e2e-aws-rhcos4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL9 Red Hat Enterprise Linux 9 product related. STIG STIG Benchmark related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants