Remove superflous check of rule ID consistency #9539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `name` attribute of `check-content-ref` element is generated by build_shorthand.py and its value is set there to rule's ID, so we don't need to verify that its set to rule's ID. See: https://github.com/ComplianceAsCode/content/blob/54f40fc7d4ea1b9bbc76a575ccb7ff91fc1c109e/ssg/build_yaml.py#L1685 and https://github.com/ComplianceAsCode/content/blob/54f40fc7d4ea1b9bbc76a575ccb7ff91fc1c109e/ssg/build_yaml.py#L1694 The check code is a leftower from past when the shorthand file used to be generated by XSLTs. Don't get confused, the `checks` variable in the removed code actually contains the `check` element and the `check` variable is actually a `check-content-ref` element.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 9399db5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 40.5% (0.1% change). View more on Code Climate. |
Mab879
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nameattribute ofcheck-content-refelement is generated by build_shorthand.py and its value is set there to rule's ID, so we don't need to verify that its set to rule's ID.See:
content/ssg/build_yaml.py
Line 1685 in 54f40fc
content/ssg/build_yaml.py
Line 1694 in 54f40fc
The check code is a leftower from past when the shorthand file used to be generated by XSLTs.
Don't get confused, the
checksvariable in the removed code actually contains thecheckelement and thecheckvariable is actually acheck-content-refelement.