Remove superflous check of rule ID consistency #9539
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
name
attribute ofcheck-content-ref
element is generated by build_shorthand.py and its value is set there to rule's ID, so we don't need to verify that its set to rule's ID.See:
content/ssg/build_yaml.py
Line 1685 in 54f40fc
content/ssg/build_yaml.py
Line 1694 in 54f40fc
The check code is a leftower from past when the shorthand file used to be generated by XSLTs.
Don't get confused, the
checks
variable in the removed code actually contains thecheck
element and thecheck
variable is actually acheck-content-ref
element.