-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify instructions for implementing SCCs #9569
Clarify instructions for implementing SCCs #9569
Conversation
94d6c9c
to
a9a82e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I kicked the one test that failed.
@Mab879 Nope, just clarifying some instructions so they're easier to understand. We wanted to have someone from CaC put eyes on it though. |
We advise users to deploy security context constraints to secure pods. This is especially important with OpenShift 4, which comes with default security context constraints enabled and ready to use. Previously, the documentation for using security context constraints was vague. This is somewhat understandable since using security context constrains is open-ended, and really depends on application and pods running within a cluster. This commit tries to clarify the instructions by briefly introducing security context constraints, and leaving the educational heavy lifting to another OpenShift document that's dedicated to describing that feature and how to use it effectively. Jira: https://issues.redhat.com/browse/OCPBUGS-698
a9a82e6
to
4415efc
Compare
Code Climate has analyzed commit 4415efc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 40.7% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We advise users to deploy security context constraints to secure pods. This is especially important with OpenShift 4, which comes with default security context constraints enabled and ready to use.
Previously, the documentation for using security context constraints was vague. This is somewhat understandable since using security context constrains is open-ended, and really depends on application and pods running within a cluster.
This commit tries to clarify the instructions by briefly introducing security context constraints, and leaving the educational heavy lifting to another OpenShift document that's dedicated to describing that feature and how to use it effectively.
Jira: https://issues.redhat.com/browse/OCPBUGS-698