Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small corrections #9644

Merged

Conversation

rumch-se
Copy link
Contributor

@rumch-se rumch-se commented Oct 6, 2022

Description:

  • _Added sle12 to prodtype into 2 rules related to cron: file_cron_deny_not_exist and file_premission_cron_allow _

Rationale:

  • The SLES 12 OS was not described in prodtype

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2022

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 6, 2022
@codeclimate
Copy link

codeclimate bot commented Oct 6, 2022

Code Climate has analyzed commit 95b8db5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 40.8% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Oct 6, 2022

@rumch-se Can you please update the description of this PR? It can be something simple, we just don't want to keep the template text.

@Mab879 Mab879 added this to the 0.1.65 milestone Oct 6, 2022
@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates. labels Oct 6, 2022
@rumch-se
Copy link
Contributor Author

rumch-se commented Oct 7, 2022

Hello @Mab879
I have updated the description on your request.
Have a nice day
Rumen

@Mab879 Mab879 self-assigned this Oct 7, 2022
@Mab879 Mab879 merged commit fc556a5 into ComplianceAsCode:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants