-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove superfluous XML namespaces from HTML tables #9662
Remove superfluous XML namespaces from HTML tables #9662
Conversation
The root element defines some XML namespaces that aren't used in any child element so we don't have to declare them.
Code Climate has analyzed commit 82ea366 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 40.8% (0.0% change). View more on Code Climate. |
Looking through the output, I see |
@Mab879 That's a great point! No, it isn't expected. They shouldn't be there. They also have a wrong namespace or don't have a namespace and
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing the comments for the PR this seems reasonable; the issues identified are pre-existing and don't need to be fixed in this PR.
The root element defines some XML namespaces that aren't used in any child element so we don't have to declare them.