Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous XML namespaces from HTML tables #9662

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

jan-cerny
Copy link
Collaborator

The root element defines some XML namespaces that aren't used in any child element so we don't have to declare them.

The root element defines some XML namespaces that aren't used
in any child element so we don't have to declare them.
@jan-cerny jan-cerny added Infrastructure Our content build system XCCDF12 labels Oct 10, 2022
@jan-cerny jan-cerny added this to the 0.1.65 milestone Oct 10, 2022
@Mab879 Mab879 self-assigned this Oct 10, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Oct 10, 2022

Code Climate has analyzed commit 82ea366 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 40.8% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Oct 10, 2022

Looking through the output, I see <sub> elements in the table outputs. For example, build/tables/table-rhel8-stig.html. Is this expected?

@jan-cerny
Copy link
Collaborator Author

@Mab879 That's a great point! No, it isn't expected. They shouldn't be there. They also have a wrong namespace or don't have a namespace and <sub> means something else in HTML. This problem isn't caused by this PR, it's present in the current upstream master as well. It also affects unlinked-stig-xccdf.xml. I think that's a bug during the generation of OCIL. Check ssg-rhel8-ocil.xml where you can find weird elements like below and these element propagate to the table.

22995       <ocil:question_text>Verify Red Hat Enterprise Linux 8 is configured to lock an account after 
22996 unsuccessful logon attempts with the command:
22997 
22998 
22999 $ grep 'deny =' /etc/security/faillock.conf
23000 deny = .
23001       Is it the case that the "deny" option is not set to "&lt;sub 
idref="var_accounts_passwords_pam_faillock_deny" /&gt;"
23002 or less (but not "0"), is missing or commented out?
23003       </ocil:question_text>

@jan-cerny
Copy link
Collaborator Author

@Mab879 I think that it's basically the same problem that is already tracked in #4354 so I have add there a comment that mentions our problems.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the comments for the PR this seems reasonable; the issues identified are pre-existing and don't need to be fixed in this PR.

@Mab879 Mab879 merged commit 760c162 into ComplianceAsCode:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system XCCDF12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants