Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pcidss Req-ids #9705

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

anivan-suse
Copy link
Contributor

Description:

This PR adds the PCI-DSS v4 Req-IDs to the following rules:

  • accounts_minimum_age_login_defs
  • accounts_no_uid_except_zero
  • accounts_password_warn_age_login_defs
  • accounts_tmout
  • accounts_umask_etc_bashrc
  • accounts_umask_etc_login_defs
  • accounts_umask_etc_profile
  • bios_enable_execution_restrictions
  • cracklib_accounts_password_pam_dcredit
  • cracklib_accounts_password_pam_lcredit
  • cracklib_accounts_password_pam_minlen
  • cracklib_accounts_password_pam_ocredit
  • cracklib_accounts_password_pam_retry
  • cracklib_accounts_password_pam_ucredit
  • install_PAE_kernel_on_x86-32
  • file_permissions_sshd_private_key
  • file_permissions_sshd_pub_key
  • no_direct_root_logins
  • no_shelllogin_for_systemaccounts
  • package_vsftpd_removed
  • package_openldap-clients_removed
  • package_chrony_installed
  • package_ypserv_removed
  • package_telnet-server_removed
  • package_audit_installed
  • package_sudo_installed
  • postfix_network_listening_disabled
  • securetty_root_login_console_only
  • sshd_disable_empty_passwords
  • sshd_disable_root_login
  • sshd_do_not_permit_user_env
  • sshd_enable_warning_banner
  • sshd_set_loglevel_verbose
  • sudo_add_use_pty
  • sudo_custom_logfile
  • use_pam_wheel_for_su

Rationale:

  • Req-IDs required to differentiate between pcidss versions

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 18, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2022

Hi @anivan-suse. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Oct 18, 2022

Code Climate has analyzed commit dd10530 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 41.2% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates. pci-dss labels Oct 18, 2022
@jan-cerny jan-cerny self-assigned this Oct 20, 2022
@jan-cerny jan-cerny added this to the 0.1.65 milestone Oct 20, 2022
@jan-cerny jan-cerny merged commit 78012f3 into ComplianceAsCode:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. pci-dss SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants