Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu 20.04: fix grub2 password related rules #9708

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Ubuntu 20.04: fix grub2 password related rules #9708

merged 4 commits into from
Oct 20, 2022

Conversation

dodys
Copy link
Contributor

@dodys dodys commented Oct 18, 2022

Description:

  • This fixes th grub2_uefi_boot_path for Ubuntu 20.04 as well as the profiles for CIS and STIG
  • Also added a Ubuntu specific OVAL for grub2_uefi as we differ from other distros.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Oct 18, 2022

Code Climate has analyzed commit 0f3c5f0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 41.0% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added OVAL OVAL update. Related to the systems assessments. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. labels Oct 18, 2022
@jan-cerny jan-cerny self-assigned this Oct 20, 2022
jan-cerny
jan-cerny approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@jan-cerny jan-cerny merged commit 0816c7f into ComplianceAsCode:master Oct 20, 2022
@jan-cerny jan-cerny added this to the 0.1.65 milestone Oct 20, 2022
@dodys dodys deleted the grub2_password branch April 17, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
OVAL OVAL update. Related to the systems assessments. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.65
Development

Successfully merging this pull request may close these issues.
3 participants
@dodys @jan-cerny @Mab879