Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ospp-mls.profile #9710

Merged
merged 1 commit into from
Oct 20, 2022
Merged

remove ospp-mls.profile #9710

merged 1 commit into from
Oct 20, 2022

Conversation

comps
Copy link
Collaborator

@comps comps commented Oct 19, 2022

Description:

  • This removes ospp-mls.profile in rhel8, an unused profile definition

Rationale:

  • This was never built and there are no present plans to ship ospp with the SELinux MLS policy in RHEL.

@comps
remove ospp-mls.profile
4d69917 
This was never built and there are no present plans to ship
ospp with the SELinux MLS policy in RHEL.

Signed-off-by: Jiri Jaburek <comps@nomail.dom>
@comps comps requested a review from a team as a code owner October 19, 2022 14:48
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2022

Hi @comps. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added this to the 0.1.65 milestone Oct 19, 2022
@Mab879 Mab879 added RHEL8 Red Hat Enterprise Linux 8 product related. Update Profile Issues or pull requests related to Profiles updates. labels Oct 19, 2022
@codeclimate
Copy link

codeclimate bot commented Oct 19, 2022

Code Climate has analyzed commit 4d69917 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 41.0% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Oct 20, 2022
jan-cerny
jan-cerny approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you very much for discovering this problem!

@jan-cerny jan-cerny merged commit 5128685 into ComplianceAsCode:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
needs-ok-to-test Used by openshift-ci bot. RHEL8 Red Hat Enterprise Linux 8 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.65
Development

Successfully merging this pull request may close these issues.
3 participants
@comps @jan-cerny @Mab879