Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 20.04: Make sure xatrr audit rules contains a check for root user #9722

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

dodys
Copy link
Contributor

@dodys dodys commented Oct 21, 2022

Description:

  • On Ubuntu 20.04 STIG V1R1, the items related to xattr (UBTU-20-010142, UBTU-20-010143, UBTU-20-010144, UBTU-20-010145, UBTU-20-010146 and UBTU-20-010147) should have a check for root user. E.g.:
-a always,exit -F arch=b32 -S setxattr -F auid>=1000 -F auid!=-1 -k perm_mod
-a always,exit -F arch=b32 -S setxattr -F auid=0 -k perm_mod                            <- Check for root
-a always,exit -F arch=b64 -S setxattr -F auid>=1000 -F auid!=-1 -k perm_mod
-a always,exit -F arch=b64 -S setxattr -F auid=0 -k perm_mod                            <- Check for root

This was missing and can easily be added by setting check_root_user to true.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2022

Hi @dodys. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Oct 21, 2022

Code Climate has analyzed commit ed4b1ea and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 46.1% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Oct 21, 2022
@jan-cerny jan-cerny added this to the 0.1.65 milestone Oct 21, 2022
@jan-cerny jan-cerny added Update Rule Issues or pull requests related to Rules updates. Ubuntu Ubuntu product related. labels Oct 21, 2022
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI fail is unrelated to the changes, the changes are only in the template data only for ubuntu 2004 and therefore they do not affect CS/Fedoru.

@jan-cerny jan-cerny merged commit e1ffbcc into ComplianceAsCode:master Oct 21, 2022
@dodys dodys deleted the audit-xattr branch April 17, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants