Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rules related to system banners - /etc/issue.net #9733

Merged
merged 6 commits into from
Oct 27, 2022

Conversation

marcusburghardt
Copy link
Member

Description:

The 1.7.6 - Ensure permissions on /etc/issue.net are configured (Automated) CIS requirement, applicable both to RHEL7 and RHEL8 was not covered. It was missing rules to check the properties of /etc/issue.net file.

This PR brings the missing rules to the project.

Rationale:

Review Hints:

The new rules use existing templates and were based on other similar rules.

@marcusburghardt marcusburghardt added New Rule Issues or pull requests related to new Rules. RHEL7 Red Hat Enterprise Linux 7 product related. RHEL8 Red Hat Enterprise Linux 8 product related. CIS CIS Benchmark related. labels Oct 26, 2022
@marcusburghardt marcusburghardt added this to the 0.1.65 milestone Oct 26, 2022
@marcusburghardt marcusburghardt requested a review from a team as a code owner October 26, 2022 08:58
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

The CCE-86042-9 was already used in the mount_option_home_grpquota but
was not removed from the list. Another was picked for the
file_permissions_etc_issue_net rule.
@codeclimate
Copy link

codeclimate bot commented Oct 26, 2022

Code Climate has analyzed commit 1784fab and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 46.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Oct 26, 2022
@marcusburghardt
Copy link
Member Author

/test e2e-aws-rhcos4-moderate

@Mab879
Copy link
Member

Mab879 commented Oct 26, 2022

/retest

@Mab879 Mab879 merged commit 29477ea into ComplianceAsCode:master Oct 27, 2022
@marcusburghardt marcusburghardt deleted the cis_banners branch October 27, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. New Rule Issues or pull requests related to new Rules. RHEL7 Red Hat Enterprise Linux 7 product related. RHEL8 Red Hat Enterprise Linux 8 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RHEL 8 CIS 1.8.1.6 Ensure permissions on /etc/issue.net are configured (Automated)
2 participants