-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new rules related to system banners - /etc/issue.net #9733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requirement 1.7.6 for CIS RHEL7 and RHEL8
Requirement 1.7.6 for CIS RHEL7 and RHEL8
Requirement 1.7.6 for CIS RHEL7 and RHEL8
The CCE-86042-9 was already used in the mount_option_home_grpquota but was not removed from the list. Another was picked for the file_permissions_etc_issue_net rule.
Code Climate has analyzed commit 1784fab and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 46.5% (0.0% change). View more on Code Climate. |
/test e2e-aws-rhcos4-moderate |
/retest |
Mab879
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
1.7.6 - Ensure permissions on /etc/issue.net are configured (Automated)
CIS requirement, applicable both to RHEL7 and RHEL8 was not covered. It was missing rules to check the properties of/etc/issue.net
file.This PR brings the missing rules to the project.
Rationale:
Review Hints:
The new rules use existing templates and were based on other similar rules.