-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to accounts_password template #9743
Add tests to accounts_password template #9743
Conversation
Hi @Xeicker. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#!/bin/bash | ||
# variables = var_password_pam_{{{ VARIABLE }}}={{{ TEST_VAR_VALUE }}} | ||
{{% if ZERO_COMPARISON_OPERATION is none %}} | ||
# platform = multi_platform_example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This multi_platform_example
doesn't exist. What is it good for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to more descriptive platform "Not Applicable". This is to mark the test as not applicable when required, so it doesn't raise any false alarms
@@ -0,0 +1,10 @@ | |||
#!/bin/bash | |||
# platform = Oracle Linux 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the test for OL 8 only? Adding a comment here would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
49eec6a
to
4a77886
Compare
Also removed tests that resulted duplicated because of this Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
4a77886
to
fa7d2ca
Compare
Code Climate has analyzed commit fa7d2ca and detected 4 issues on this pull request. Here's the issue category breakdown:
Note: there is 1 critical issue. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 46.5% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have run multiple rules in the rule mode on both Ansible and Bash remediation and everything has given the expected results. Thanks for this PR!
Description:
accounts_password
templateRationale:
Review Hints: