Pci dss shadow rule #9756
Pci dss shadow rule #9756
Conversation
|
Hi @anivan-suse. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: sle12 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
| @@ -0,0 +1,4 @@ | |||
| # platform = multi_platform_sle | |||
|
|
|||
| grep ^shadow:[^:]*:[^:]*:[^:]+ /etc/group | |||
There was a problem hiding this comment.
The CI fail seems a legit problem:
214/263 Test #215: sle15-bash-shellcheck .................................................***Failed 15.39 sec
In /__w/content/content/build/sle15/fixes/bash/ensure_shadow_group_empty.sh line 3:
grep ^shadow:[^:]*:[^:]*:[^:]+ /etc/group
^-----------------------^ SC2062: Quote the grep pattern so the shell won't interpret it.
For more information:
https://www.shellcheck.net/wiki/SC2062 -- Quote the grep pattern so the she...
Please fix this
| cce@sle12: CCE-92213-8 | ||
| cce@sle15: CCE-91344-2 |
There was a problem hiding this comment.
Please remove the used CCE from shared/references/cce-sle12-avail.txt and shared/references/cce-sle15-avail.txt.
| Remove all users from the shadow group, and change the primary group of any | ||
| users with shadow as their primary group. |
There was a problem hiding this comment.
This sentence is more a fixtext than ocil.
anivan-suse
force-pushed
the
pci-dss-shadow-rule
branch
from
fcb7640
to
93cd4c0
Compare
jan-cerny
added
SLES
|
Code Climate has analyzed commit 2562f99 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 46.7% (0.0% change). View more on Code Climate. |
Description:
Add new rule to PCI-DSS-4