Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the utils/srg_diff.py more generic #9767

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Nov 4, 2022

Description:

  • Rename DISA -> Base
  • Rename CaC -> Target
  • Update output flag to have default location and add it to the help text

Rationale:

DISA and CaC didn't sell how the script works. Target and base help sell it better.

@Mab879 Mab879 added the Infrastructure Our content build system label Nov 4, 2022
@Mab879 Mab879 added this to the 0.1.65 milestone Nov 4, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

DISA and CaC didn't really sell how the script works.
Target and base help sell it better.
@codeclimate
Copy link

codeclimate bot commented Nov 4, 2022

Code Climate has analyzed commit 65381a9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 46.7% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Nov 7, 2022
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have compared the Excel from the current upstream with the item downloaded from the latest DISA submission and the generator of the diff worked for me.

@jan-cerny jan-cerny merged commit a0f2b1e into ComplianceAsCode:master Nov 7, 2022
@Mab879 Mab879 deleted the make_srg_more_generic branch November 7, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants