build_remediations.py: deduplicate code which retrieves conditionals #9779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemediationObject is a namedtuple. Before it was defined on several places. Now it has one definition and the definition is reused.
… remediations This commit deduplicates code. There are two new pairs of functions created. Two functions to get platform names of inherited conditionals or rule-specific conditionals. These platform names can be used in the remaining two functions to get actual conditionals. Then there is another function which strips conditionals of whitespaces at their begining or end. These functions are used in BashRemediation and AnsibleRemediation class.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
as reported by Code climate
|
Code Climate has analyzed commit 505c061 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 88.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 46.8% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Code for retrieving remediation conditionals of rules was duplicated. Now the processing is defined at one place.
See commit messages for more information.
Rationale:
Deduplication of code.