Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI ansible hardening and rename of existing Bash hardening #9796

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Nov 9, 2022

Description:

Update existing machine-hardening Testing Farm tests to explicitly mention they are testing Bash - update their description and test case name.

Add ansible-machine-hardening Testing Farm test - the test is very similar to existing machine-hardening test but hardens using ansible-playbook.
Test case was introduced in https://src.fedoraproject.org/tests/scap-security-guide/pull-request/20 and this PR references it.

Rationale:

Extend CI with Ansible tests.

Review Hints:

See testing-farm:centos-stream-* checks.

@mildas mildas marked this pull request as draft November 9, 2022 10:11
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Nov 9, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@mildas mildas changed the title [DO NOT MERGE] CI ansible hardening [DO NOT MERGE] CI ansible hardening and rename of existing Bash hardening Nov 9, 2022
@mildas
Copy link
Contributor Author

mildas commented Nov 9, 2022

/packit test

@mildas mildas marked this pull request as ready for review November 16, 2022 11:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Nov 16, 2022
@mildas mildas changed the title [DO NOT MERGE] CI ansible hardening and rename of existing Bash hardening CI ansible hardening and rename of existing Bash hardening Nov 16, 2022
@mildas
Copy link
Contributor Author

mildas commented Nov 16, 2022

I have removed STIG ansible-machine-hardening test because in current form it's not suitable for CI - it takes too long to on RHEL8.
Only OSPP test case is introduced now. When it's merged, I will introduce other suitable profiles.

@codeclimate
Copy link

codeclimate bot commented Nov 16, 2022

Code Climate has analyzed commit 6d33d9c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 47.2% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Nov 16, 2022
@marcusburghardt marcusburghardt added the Test Suite Update in Test Suite. label Nov 17, 2022
@marcusburghardt marcusburghardt added this to the 0.1.65 milestone Nov 17, 2022
@marcusburghardt marcusburghardt added enhancement General enhancements to the project. Ansible Ansible remediation update. labels Nov 17, 2022
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have checked the logs of this new test. They are not only working fine but are capable to reveal Ansible issues which are not easy to be caught when analyzing individual rules. I believe this new test will bring a great value for the project by allowing us to raise the bar regarding Ansible playbooks quality. Thanks for this improvement.

@marcusburghardt marcusburghardt added the Highlight This PR/Issue should make it to the featured changelog. label Nov 17, 2022
@marcusburghardt marcusburghardt merged commit fcc1954 into ComplianceAsCode:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. enhancement General enhancements to the project. Highlight This PR/Issue should make it to the featured changelog. Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants