-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI ansible hardening and rename of existing Bash hardening #9796
CI ansible hardening and rename of existing Bash hardening #9796
Conversation
/packit test |
0b87923
to
425e0da
Compare
425e0da
to
6d33d9c
Compare
I have removed STIG |
Code Climate has analyzed commit 6d33d9c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 47.2% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have checked the logs of this new test. They are not only working fine but are capable to reveal Ansible issues which are not easy to be caught when analyzing individual rules. I believe this new test will bring a great value for the project by allowing us to raise the bar regarding Ansible playbooks quality. Thanks for this improvement.
Description:
Update existing
machine-hardening
Testing Farm tests to explicitly mention they are testing Bash - update their description and test case name.Add
ansible-machine-hardening
Testing Farm test - the test is very similar to existingmachine-hardening
test but hardens usingansible-playbook
.Test case was introduced in https://src.fedoraproject.org/tests/scap-security-guide/pull-request/20 and this PR references it.
Rationale:
Extend CI with Ansible tests.
Review Hints:
See
testing-farm:centos-stream-*
checks.