Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align service_disabled template to service_enabled #9806

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Nov 11, 2022

Description:

Disable services using service module, similarly as service_enabled template does.

Rationale:

Current service_disabled template is not compatible with Ansible 2.14 where warn was removed.

https://docs.ansible.com/ansible/latest/collections/ansible/builtin/command_module.html#parameter-warn

This feature is deprecated and will be removed in 2.14.

Causing fatal error on CentOS Stream 9 https://artifacts.dev.testing-farm.io/16b16e84-93e7-4ee4-baca-0e22ca55d5eb/

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Nov 11, 2022

Code Climate has analyzed commit dc37d3c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 47.2% (0.0% change).

View more on Code Climate.

@mildas mildas added the Ansible Ansible remediation update. label Nov 11, 2022
@mildas
Copy link
Contributor Author

mildas commented Nov 11, 2022

/packit build

@Mab879 Mab879 self-assigned this Nov 11, 2022
@Mab879 Mab879 added this to the 0.1.65 milestone Nov 11, 2022
@Mab879
Copy link
Member

Mab879 commented Nov 11, 2022

/packit retest-failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants