SRG Export XLSX in CMake #9811
Merged
SRG Export XLSX in CMake #9811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
Mab879
force-pushed
the
srg_export_target
branch
from
bf93136
to
f7b748a
Compare
jan-cerny
requested changes
Nov 14, 2022
To make the script not output when used in things like the build system.
So that SRG diff creation process is taken from a four-step process to a two-step process.
Mab879
force-pushed
the
srg_export_target
branch
from
f7b748a
to
6cfe5bc
Compare
|
Code Climate has analyzed commit 2a10bef and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 47.2% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Nov 14, 2022
|
/packit test |
|
/packit test |
|
The CI fail in Fedora rawhide is unrelated to this PR, it's caused by libxml2 ABI break, see https://bugzilla.redhat.com/show_bug.cgi?id=2139546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the ability to create the XLSX files from
utils/create_srg_exportfrom the build system.Rationale:
This PR makes using the
utils/srg_diff.pyscript much easier. Instead of running a four-step process (building, creating rule_dir_json, creating the SRG export, then creating the SRG Diff HTML report), this PR brings it to two steps (building the product and creating the SRG Diff HTML report).Review Hints:
ADDITIONAL_CMAKE_OPTIONS="-DSSG_SRG_XLSX_EXPORT=ON" ./build_product -j9 rhel9