Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLE 12/15 CCE and CIS numbers for the CIS group job schedulers #9883

Merged

Conversation

rumch-se
Copy link
Contributor

Description:

  • _Assignment of CCE numbers or update/add of CIS numbers to the SLE 12/15 rules which a part of CIS group 5.1 Configure time-based job schedulers _

Rationale:

  • Some of SLE 12/15 rules which a part of CIS group 5.1 Configure time-based job schedulers did not have CCE numbers assigned or their CIS numbers were not correct

Review Hints:

  • Review hints here. Replace this text. Don't use the italics format!

  • Use this optional section to give any relevant information which could help the reviewer to more quickly and assertively understand and test the changes.

  • Good examples are useful commands, if it is better to review all commits together or in a suggested sequence, any relevant discussion in other PRs or issues, etc.

@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2022

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 25, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Nov 30, 2022
@marcusburghardt marcusburghardt added the SLES SUSE Linux Enterprise Server product related. label Nov 30, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Dec 2, 2022
@rumch-se
Copy link
Contributor Author

rumch-se commented Dec 2, 2022

Hello @marcusburghardt
I have done rebase.
Have a nice day
Rumen

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Dec 2, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Dec 5, 2022
@rumch-se
Copy link
Contributor Author

rumch-se commented Dec 5, 2022

Hello @marcusburghardt
I have done rebase.
Have a nice day
Rumen

CCE-92272-4
CCE-92273-2
CCE-92274-0
CCE-92275-7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are probably removing more CCEs than necessary in this PR. Could you check, please?

CCE-91388-9
CCE-91389-7
CCE-91390-5
CCE-91391-3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are probably removing more CCEs than necessary in this PR. Could you check, please?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Dec 8, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Dec 8, 2022
@rumch-se
Copy link
Contributor Author

rumch-se commented Dec 8, 2022

Hello @marcusburghardt
I have done rebase and now the numbers used for the rules correspond to the numbers taken from the files with available numbers.
Have a nice day
Rumen

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@marcusburghardt marcusburghardt self-assigned this Dec 8, 2022
@marcusburghardt marcusburghardt added the CIS CIS Benchmark related. label Dec 8, 2022
@codeclimate
Copy link

codeclimate bot commented Dec 8, 2022

Code Climate has analyzed commit f13877c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 48.8% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt merged commit 87fda05 into ComplianceAsCode:master Dec 8, 2022
@Mab879 Mab879 added this to the 0.1.66 milestone Dec 8, 2022
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants