Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the file param in rule_dir_json #9928

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Dec 5, 2022

Description:

Minor fix to the quiet_print function in utils/rule_dir_json.py.

Rationale:

Fix issues like this.

Product ubuntu1804 has multiple remediations of the same type in rule rsyslog_remote_access_monitoring: shared.sh,shared.yml,ubuntu.sh <_io.TextIOWrapper name='<stderr>' mode='w' encoding='utf-8'>
Product ubuntu1604 has multiple remediations of the same type in rule rsyslog_remote_access_monitoring: shared.sh,shared.yml,ubuntu.sh <_io.TextIOWrapper name='<stderr>' mode='w' encoding='utf-8'>
Product ubuntu2204 has multiple remediations of the same type in rule rsyslog_remote_access_monitoring: shared.sh,shared.yml,ubuntu.sh <_io.TextIOWrapper name='<stderr>' mode='w' encoding='utf-8'>
Product ubuntu2004 has multiple remediations of the same type in rule rsyslog_remote_access_monitoring: shared.sh,shared.yml,ubuntu.sh <_io.TextIOWrapper name='<stderr>' mode='w' encoding='utf-8'>

@Mab879 Mab879 added the Infrastructure Our content build system label Dec 5, 2022
@Mab879 Mab879 added this to the 0.1.66 milestone Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Dec 5, 2022

Code Climate has analyzed commit 677697a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 48.8% (0.0% change).

View more on Code Climate.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@marcusburghardt marcusburghardt self-assigned this Dec 12, 2022
@marcusburghardt marcusburghardt merged commit 036e790 into ComplianceAsCode:master Dec 12, 2022
@Mab879 Mab879 deleted the fix_print_rule_dir_json branch December 12, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants